Draft
Conversation
Changes: - contactPoint: change to mandatory; remove option for null value; add to required array - identifier: change to mandatory; remove option for null value; add to required array - keyword: remove "minLength": 1 restriction - next / nextVersion: add to jsonschema; mirror prev / previousVersion schema - rights: change to an array
Author
|
I'm going to break this PR up into smaller ones that are oriented around the specific changes (e.g., an identifier PR, a contactPoint PR, a consistency between classes PR) and will also create issues around some of the discussion items. Will close once done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Should resolve: #43
Documentation: Dataset
Notes
accrualPeriodicity-Frequencyclass issue is being addressed in a separate PR (currently draft)Changes:
contactPoint- change to mandatory; remove option for null value; add to required arrayDatasetlevel in DCAT-US 1.1, so no backward compatibility issueidentifier- change to mandatory; remove option for null value; add to required arrayDatasetlevel in DCAT-US 1.1keyword- remove"minLength": 1restriction. Do we know why this was included?next / nextVersion- in documentation but missing from jsonschema; add to jsonschema; mirrorprev / previousVersionschemarights- change to an array; matches documentation and makes sense given the property's usage as a catch-all for legal related metadata that is not covered byaccessRightsorlicenseDiscussion Topics
supportedSchema,first,hasCurrentVersion,created,rightsHolder,hasPart,replaces,wasAttributedTo,wasUsedBydcat:Resourceproperties (at least some) and five of them can be found in the documentation for other related classes (i.e.,DataService.created,DataService.rightsHolder,DataService.wasUsedBy,DataSeries.first, andCatalog.hasPart).Dataset, but I know we've generally aired on the side of leaving extra properties in case someone wants to use them.status- accepts aConceptobject or string IRI; CV (VOCAB-ADMS-SKOS) has an unresolvable URLCompleted,Deprecated,Under Development,Withdrawntheme/category- DATA-GOV-THEMEConceptaccessRights- DATA-GOV-ARaccessLevel(DCAT-US 1.1)public,restricted public,non-public