standardize "identifier" usage across all relevant classes#95
Open
zopalmer14 wants to merge 2 commits intomainfrom
Open
standardize "identifier" usage across all relevant classes#95zopalmer14 wants to merge 2 commits intomainfrom
zopalmer14 wants to merge 2 commits intomainfrom
Conversation
Relevant classes: Catalog, Data Service, Dataset, Distribution, Document, Location, Standard Changes: - Identfier class - add flexibility to allow it to be either a simple string or the more complex original definition of Identifier - identifier - Ensure all occurrences accept a single entry and not a list - All occurrences should accept either null or an Identifier object (i.e., an inline description or a string IRI) - otherIdentifier - Add to all relevant classes that are currently missing it (i.e., all except Dataset) - All occurrences should accept either null or a list of Identifier objects
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should resolve: #93
Relevant classes:
Catalog,Data Service,Dataset,Distribution,Document,Location,StandardChanges:
IdentfierclassIdentifieridentifierIdentifierobject (i.e., an inline description or a string IRI)otherIdentifierDataset)IdentifierobjectsFor Discussion
While this should resolve the inconsistency in identifier usage across all of the relevant classes, allowing for both complex and simple identifier usage, there is still the issue of
identifiernot being required/mandatory in any of the classes at present. At minimum, it should be required forDatasetfor backwards compatibility purposes and to allow Data.gov to manage/track changes to agency catalogs; however, I thought it might be worth discussing if there are any other classes where it might make sense to requireidentifier, in which case we can tackle all of the changes in one issue/PR.