SRCH-5787: Replace existing searchgov style gem with rubocop gem#369
Conversation
| # https://github.com/GSA/searchgov_style/blob/main/.codeclimate.yml | ||
| gem 'searchgov_style', '~> 0.1', require: false | ||
| gem 'rubocop', require: false | ||
| gem 'rubocop-discourse', require: false |
There was a problem hiding this comment.
We don't need this! Please remove it. Same with rubocop-minitest.
There was a problem hiding this comment.
@stevenbarragan - I have removed the gems. Although, even with it gone, I am still not able to run the bundle exec rubocop --auto-gen-config command successfully. As mentioned, might be a local issue if you plan on testing this in your machine.
stevenbarragan
left a comment
stevenbarragan
left a comment
There was a problem hiding this comment.
Please remove unnecessary dependencies and clean commit history.
| # Offense count: 4 | ||
| # Configuration parameters: Include. | ||
| # Include: app/controllers/**/* | ||
| Discourse/Plugins/CallRequiresPlugin: |
There was a problem hiding this comment.
You need to anything discourse related!
There was a problem hiding this comment.
@stevenbarragan - I have removed all related items to discourse from changes ... including inline comments from offenses.
Was able to fix the history issue with commits. |
…ions for rubocop. Linter.
|
You don't need to pull but rebase main into your branch. Maybe you can run a rebase -i (interactive) to pick the commits you want to push. Check this https://medium.com/@tigerasks/git-gud-b29c11ab2c60 and https://www.reddit.com/r/git/comments/18thhel/maintain_a_semilinear_history/?rdt=49382 I actually just changed my comment to got it updated. Yeah, it looks like my forked branches where pretty far behind. Without interactive rebase, it would have continued to add other commits to my merger. Should be good now |
SRCH-5787: Replace existing searchgov style gem with rubocop gem (#369)
3 participants
Summary
JIRA Ticket: https://cm-jira.usa.gov/browse/SRCH-5787
Checklist
Please ensure you have addressed all concerns below before marking a PR "ready for review" or before requesting a re-review. If you cannot complete an item below, replace the checkbox with the⚠️
:warning:emoji and explain why the step was not completed.Functionality Checks
You have merged the latest changes from the target branch (usually
main) into your branch.Your primary commit message is of the format SRCH-#### <description> matching the associated Jira ticket.
PR title is either of the format SRCH-#### <description> matching the associated Jira ticket (i.e. "SRCH-123 implement feature X"), or Release - SRCH-####, SRCH-####, SRCH-#### matching the Jira ticket numbers in the release.
Automated checks pass. If Code Climate checks do not pass, explain reason for failures:
Process Checks