notify-162 delete incomplete s3 uploads #276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Terraform Format and Style: success Show PlanPusher: @terrazoon, Action: |
|
Terraform Format and Style: success Show PlanPusher: @terrazoon, Action: |
ccostino
reviewed
May 23, 2023
Contributor
ccostino
left a comment
ccostino
left a comment
There was a problem hiding this comment.
Thanks, @terrazoon! Everything looks fine to me, including the new test, thanks!
I just had one question for clarification before I approve, and it's likely just me being unfamiliar with the code base. :-) Thanks!
ccostino
approved these changes
May 23, 2023
Contributor
ccostino
left a comment
ccostino
left a comment
There was a problem hiding this comment.
Thanks again, @terrazoon!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run a task every hour to look for jobs that started 4 hours ago and have not finished yet. If they have not finished, delete the original_file_name associated with the job from the CSV bucket and archive the job.