tag: official tag responsive ui#113
Merged
Merged
Conversation
samanthabaker
requested review from
carlosvalle,
christyhermansen,
davereed and
thomastighe
as code owners
carlosvalle
suggested changes
Oct 29, 2019
| } | ||
|
|
||
| @media only screen and (max-width: 600px) { | ||
| @media only screen and (max-width: 640px) { |
Contributor
There was a problem hiding this comment.
if you use utility classes it will make this component much more flexible - example sam-styles/src/components/patterns/page/page-with-sidebar.njk line 54, 65, 76
Contributor
Author
There was a problem hiding this comment.
The designers asked that this never be shown on mobile versions, and it behaves odd if I don't make it display:none at 640px width
carlosvalle
approved these changes
Oct 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
style updated for tag component