Conversation
cwolf10
requested review from
Bibek-Regmi,
christyhermansen,
davereed,
samanthabaker and
yerramshilpa
as code owners
Bibek-Regmi
reviewed
Feb 3, 2022
| } | ||
| } | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Let's use the variable theme tokens instead of hard coding hex values
Contributor
Author
There was a problem hiding this comment.
doh. should be pushed now
Bibek-Regmi
reviewed
Feb 3, 2022
| background-color: #81aefc; | ||
| } | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Do all browsers support webkit css?
Contributor
Author
There was a problem hiding this comment.
Good catch, got the other browser's selectors added
Bibek-Regmi
suggested changes
Feb 3, 2022
Contributor
Bibek-Regmi
left a comment
Bibek-Regmi
left a comment
There was a problem hiding this comment.
Update on hard coded hex values and investigation into defining css through webkit only selectors
Bibek-Regmi
approved these changes
Feb 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.