IAE-23322 Results list updates#69
Conversation
davereed
requested review from
carlosvalle and
christyhermansen
as code owners
| @@ -1,3 +1,8 @@ | |||
| .result-item-wrapper { | |||
| height: 2.1rem; | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
could you move tag related css to src/stylesheets/elements/_tags.scss
There was a problem hiding this comment.
I moved the display related classes out of inputs
| @@ -1,26 +1,24 @@ | |||
| .sds-tag--info-purple { | |||
There was a problem hiding this comment.
colors should be added by using the color() function example color: color('primary');
| // Layouts | ||
| // ------------------------------------- | ||
| @import '../layouts/subheader'; | ||
| @import '../layouts/page'; |
There was a problem hiding this comment.
adding this could be misunderstood/misuse by some developers. Developers could think that page specific styles could be added here - All css should be broken down in to components and add it to their corresponding folder
There was a problem hiding this comment.
I moved the sds-page css to a component file, hopefully this is more clear.
| @@ -42,6 +42,7 @@ SDS THEME CUSTOM STYLES | |||
| // Layouts | |||
| // ------------------------------------- | |||
| @import '../layouts/subheader'; | |||
There was a problem hiding this comment.
I'll be removing subheader as this seems to be causing confusion about the structure of the css
| @@ -0,0 +1,44 @@ | |||
| sds-page { | |||
There was a problem hiding this comment.
most of these styles are border related css - I think it will make sense to create a borders file. After moving the border styles from this file. The rest of the styles could be achieved by utilities.
There was a problem hiding this comment.
Moved border and sizing out to their own files
| } | ||
|
|
||
| div[class^="grid-col-"] .sds-tag--static, div[class*=" grid-col-"] .sds-tag--static { | ||
| div[class^="grid-col-"] .sds-tag--static, |
There was a problem hiding this comment.
This will affect all the tags inside a grid-col not only the tags located in the searchlist component
There was a problem hiding this comment.
Nothing else was using this class, but I renamed and moved this to tags and created a block style modifier rather than calling it static.
| */ No newline at end of file | ||
| */ | ||
|
|
||
| $theme-header-min-width: 'desktop' !default; |
There was a problem hiding this comment.
This variable is for the header component - could you remove it from this PR
| @@ -1,3 +1,8 @@ | |||
| .result-item { | |||
There was a problem hiding this comment.
components should start with 'sds' prefix
2 participants
No description provided.