Skip to content

Inverted hideHint default value #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
colinalford-gsa merged 1 commit into from
Sep 18, 2018
Merged

Inverted hideHint default value #67

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/ui-kit/form-controls/autocomplete-multiselect/autocomplete-multiselect.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ export class SamAutocompleteMultiselectComponent
/**
* set to false if more/less is not required
*/
@Input() public hideHint : boolean = true;
@Input() public hideHint : boolean = false;
/**
* Used by labelWrapper. Provides a name for input and label.
* See labelWrapper for more detail.
Expand Down
2 changes: 1 addition & 1 deletion src/ui-kit/form-controls/autocomplete/autocomplete.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ export class SamAutocompleteComponent
/**
* set to false if more/less is not required
*/
@Input() public hideHint : boolean = true;
@Input() public hideHint : boolean = false;
/**
* Define autocomplete options
*/
Expand Down
2 changes: 1 addition & 1 deletion src/ui-kit/wrappers/label-wrapper/label-wrapper.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export class LabelWrapper implements AfterViewChecked {
/**
* set to false if more/less is not required
*/
@Input() public hideHint : boolean = true;
@Input() public hideHint : boolean = false;

/**
* set the error message
Expand Down
6 changes: 3 additions & 3 deletions src/ui-kit/wrappers/label-wrapper/label-wrapper.template.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,11 @@
class="usa-form-hint"
[attr.id]="hintElId"
[innerHTML]="hint"
[style.overflow]="showToggle && hideHint && !toggleOpen ? 'hidden' : '' "
[style.height]="showToggle && hideHint && !toggleOpen ? '2.88em' : '' ">
[style.overflow]="showToggle && !hideHint && !toggleOpen ? 'hidden' : '' "
[style.height]="showToggle && !hideHint && !toggleOpen ? '2.88em' : '' ">
</div>

<div *ngIf="showToggle && hideHint"
<div *ngIf="showToggle && !hideHint"
class="toggle-more">
<a href="javascript:void(0)"
(click)="toggleHint(toggleOpen)">
Expand Down