Conversation
…ncluded in the release.
mark-meyer
left a comment
mark-meyer
left a comment
There was a problem hiding this comment.
There's one small thing noted in a comment — just looks like leftover code that should probably be deleted. But lets fix that before pushing.
It looks like the Vue components are still in progress, but it we don't have tests for new components yet. The coverage report won't tell you about new code that don't have a .spec file, so the front-end coverage report will be a little too forgiving. Lets not let this hold up this PR, but we should have test for Vue components as well as the python tests (which look nice here) as this develops. There should be a lot of go-bys in the training-front-end/src/components/__tests__ directory.
training/schemas/gspc_invite.py
Outdated
| @field_validator('certification_expiration_date') | ||
| @classmethod | ||
| def check_certification_expiration_date(cls, value): | ||
| value is datetime |
There was a problem hiding this comment.
This seems a little strange — just an expression doing nothing. Maybe it was meant to be deleted or should be a comment?
There was a problem hiding this comment.
Nice catch. Code was used for debugging. Redundant code has been removed.
* Updated USWDS library version from 3.6.1 to 3.7.1. (#479) * Addressed various front-end library vulnerabilities flagged by Dependabot. (#495) * Gsa/production release (#511) * Sprint 25 Issue #456 GSPC | Email Title and Content Once User Initially Attempts to Begin GSPC Verification Issue #419 Administrator | Loading GSPC Eligible List into the Training System Issue #494 Create Training - Admin Landing Page Issue #496 Dependabot Alert: FastAPI Content-Type Header ReDoS * Reverting Sprint 26 change. Has not been reviewed and should not be included in the release. * Removed redundant code per Code Review * Fixed broken user search link in the admin console (#514) * Production Release (#522) Includes: Issue #498 Dependabot Alert: NPM IP package vulnerable to Server-Side Request Forgery (SSRF) attacks Issue #181 Administrator | Edit User Issue #508 Footer Changes for SmartPay Training Site Issue #504 Update A/OPC Training Content Lesson 3 * Production Release (#527) Includes issue(s): Issue #515 Update USWDS from 3.71 to 3.8 | Training Website Issue #510 Bug: Update content in email sent to GSPC Attendees Issue #509 Add button to the Send Invitations for GSA SmartPay Program Certification screen
* Sprint 25 Issue #456 GSPC | Email Title and Content Once User Initially Attempts to Begin GSPC Verification Issue #419 Administrator | Loading GSPC Eligible List into the Training System Issue #494 Create Training - Admin Landing Page Issue #496 Dependabot Alert: FastAPI Content-Type Header ReDoS * Reverting Sprint 26 change. Has not been reviewed and should not be included in the release. * Removed redundant code per Code Review
2 participants
Issue #456 GSPC | Email Title and Content Once User Initially Attempts to Begin GSPC Verification
Issue #419 Administrator | Loading GSPC Eligible List into the Training System
Issue #494 Create Training - Admin Landing Page
Issue #496 Dependabot Alert: FastAPI Content-Type Header ReDoS