Kotlin java semicolon build error #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arpankumarlahiri
changed the title
Owner
|
Thanks, this change seems fine! I'll merge it. |
Contributor
|
Confirm it compiles and works in RN 50 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am using the plugin for my project and found out it fails to build with above error...
I am using Expo 49
Some deep dive suggested issue with src/android/mainApplicationDependency.ts file...
addBelowAnchorIfNotFound is not running for 49 as the condition for 50 is modifying the content..
I am new to open source and never contributed before, hope this pr helps to fix the issue...
I used the changes to eas build and it worked..
PS: Not tried in 50.