NetherOres crash

[Omgise]

crash-2024-11-17_08.09.14-client.txt
fml-client-latest.log

[branman5949]

This is the same exact crash I got. Its because of the NetherOres mod. I checked it myself. We have to wait for False to fix compatibility with it.

[OmegaHaxors]

I went to the exact point that throws the NPE (registerDefaultBlockTranslucencyColors) and there seems to be some pretty naïve code that assumes that if the domain is minecraft: that it must be a vanilla block. However, in the case of NetherOres, they override Nether Quartz with their own value while retaining the original block information, meaning it keeps its domain despite being essentially a replacement block.

The simple fix is to bypass this step for nether quartz if the mod is installed, though a more ideal solution should be looked into. For the time being i'll be attempting a fix on the bytecode level, and will return my results if I find a solution that works.

Wait... WHAT??!? It's caused by getting UniqueIdentifier.modId?!?

[OmegaHaxors]

I found the issue. It's at line 532 of registerDefaultBlockTranslucencyColors:
Use the == operator instead of .equals() when comparing strings. The former will return FALSE if one of the operands is null, the latter will throw an exception and then crash.

Finally got the blasted thing to run. Here is the fix:
if (blockId == null || !blockId.modId.equals("minecraft")) continue;

[branman5949]

I found the issue. It's at line 532 of registerDefaultBlockTranslucencyColors: Use the == operator instead of .equals() when comparing strings. The former will return FALSE if one of the operands is null, the latter will throw an exception and then crash.

Finally got the blasted thing to run. Here is the fix: if (blockId == null || !blockId.modId.equals("minecraft")) continue;

Hey if you're still around would you mind posting the fix for NetherOres? I don't know where "registerDefaultBlockTranslucencyColors:" is located in terms of the netherores mod but I would really appreciate it