Skip to content

make MetaItem, MetaTileEntity, and Material IDs configurable#362

Merged
tier940 merged 3 commits intomasterfrom
tier-ids
Apr 6, 2026
Merged

make MetaItem, MetaTileEntity, and Material IDs configurable#362
tier940 merged 3 commits intomasterfrom
tier-ids

Conversation

@tier940
Copy link
Copy Markdown
Member

@tier940 tier940 commented Apr 6, 2026

No description provided.

@tier940 tier940 self-assigned this Apr 6, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the mod's flexibility by moving hardcoded IDs for various game elements into a configurable system. By allowing users to define start IDs for MetaItems, MetaTileEntities, and Materials, the change significantly improves compatibility with other mods that might otherwise cause ID conflicts. The implementation uses a base-plus-offset approach, ensuring that the default behavior remains unchanged for existing installations.

Highlights

  • Configurable IDs: Introduced configuration options for MetaItem, MetaTileEntity, and Material IDs to allow users to resolve potential ID conflicts with other mods.
  • Dynamic ID Calculation: Refactored the registration logic for materials and machines to use configurable start IDs as a base, with individual IDs calculated as offsets.
  • Backward Compatibility: Ensured that default configuration values match the previously hardcoded IDs, maintaining compatibility with existing worlds.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@tier940 tier940 linked an issue Apr 6, 2026 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

このプルリクエストは、MetaItem、MetaTileEntity、およびMaterialのIDをコンフィグから設定可能にするものです。各カテゴリに開始IDを導入し、個別のIDをオフセットとして計算するように修正されました。レビューでは、ハードコードされたID範囲を記載している古いJavadocの更新、不要な括弧の削除、およびマジックナンバーを定数に置き換えることによる保守性の向上が提案されています。

@tier940 tier940 merged commit 0605357 into master Apr 6, 2026
2 checks passed
@tier940 tier940 deleted the tier-ids branch April 6, 2026 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash with Greg's Tinkering

1 participant