Skip to content

Fixed GT main-hand + TiC off-hand combination dropping items twice#11

Merged
tier940 merged 3 commits intomasterfrom
tier-tic-dualtool-use-2
Apr 10, 2026
Merged

Fixed GT main-hand + TiC off-hand combination dropping items twice#11
tier940 merged 3 commits intomasterfrom
tier-tic-dualtool-use-2

Conversation

@tier940
Copy link
Copy Markdown
Member

@tier940 tier940 commented Apr 10, 2026

No description provided.

@tier940 tier940 self-assigned this Apr 10, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a duplication bug occurring when combining GregTech and Tinkers' Construct tools across hands. By adjusting how the mod interacts with vanilla harvest checks and refining the off-hand preference logic, the system now correctly delegates block breaking and item dropping to the game's native handlers, ensuring that items are only dropped once per block break.

Highlights

  • Bug Fix: Resolved an issue where using a GregTech main-hand tool with a Tinkers' Construct off-hand tool caused blocks to drop items twice.
  • Logic Refactoring: Updated the cross-hand mining logic to rely on vanilla harvest handling, ensuring consistent behavior and preventing duplicate drop events.
  • Code Cleanup: Improved documentation and simplified mixin logic for better maintainability and clarity regarding off-hand tool interaction.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

このプルリクエストは、GregTech (GT) のメインハンドと Tinkers' Construct (TiC) のオフハンドを併用した際にアイテムが二重にドロップする問題を修正します。主な変更として、DualToolHandler での手動ドロップ処理を廃止してバニラの収穫ロジックに統合し、ツール優先度の判定ロジックを MixinDualToolHarvestUtils へ整理しています。レビューの結果、MixinForgeHooks でのメソッド指定の曖昧さと NPE のリスク、ハンドスワップ発生時のツール耐久値減少の不備、およびツールが必須でないブロックに対するスワップ最適化の余地について改善が求められています。

Comment thread src/main/java/com/github/gtexpert/gtmt/mixins/tic/MixinForgeHooks.java Outdated
@tier940 tier940 merged commit 9658af7 into master Apr 10, 2026
2 checks passed
@tier940 tier940 deleted the tier-tic-dualtool-use-2 branch April 10, 2026 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant