Fixed GT main-hand + TiC off-hand combination dropping items twice#11
Fixed GT main-hand + TiC off-hand combination dropping items twice#11
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a duplication bug occurring when combining GregTech and Tinkers' Construct tools across hands. By adjusting how the mod interacts with vanilla harvest checks and refining the off-hand preference logic, the system now correctly delegates block breaking and item dropping to the game's native handlers, ensuring that items are only dropped once per block break. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
このプルリクエストは、GregTech (GT) のメインハンドと Tinkers' Construct (TiC) のオフハンドを併用した際にアイテムが二重にドロップする問題を修正します。主な変更として、DualToolHandler での手動ドロップ処理を廃止してバニラの収穫ロジックに統合し、ツール優先度の判定ロジックを MixinDualToolHarvestUtils へ整理しています。レビューの結果、MixinForgeHooks でのメソッド指定の曖昧さと NPE のリスク、ハンドスワップ発生時のツール耐久値減少の不備、およびツールが必須でないブロックに対するスワップ最適化の余地について改善が求められています。
No description provided.