Skip to content

fix stickLong recipe#13

Merged
MrKono merged 3 commits intomasterfrom
kono/fixRodRecipe
Apr 24, 2026
Merged

fix stickLong recipe#13
MrKono merged 3 commits intomasterfrom
kono/fixRodRecipe

Conversation

@MrKono
Copy link
Copy Markdown
Member

@MrKono MrKono commented Apr 24, 2026

No description provided.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a missing recipe issue for long sticks within the Storage Drawers integration. By checking for material properties, it ensures that materials without standard ingot or gem forms can still be processed correctly using the extruder.

Highlights

  • Recipe Fix: Added a new extruder recipe for stickLong to support materials that lack Ingot or Gem properties.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new extruder recipe for materials that lack both Ingot and Gem properties to support Storage Drawers integration. I have reviewed the logic and identified a bug in the conditional check: the current implementation uses an OR operator, which would incorrectly register recipes for materials that possess one of the two properties. I have suggested changing this to an AND operator to ensure the recipe is only registered for materials that truly lack both.

addStorageUpgradeConvertRecipe(Mods.StorageDrawers.getItem("upgrade_storage", 1, 4), output, material);
}

if (!material.hasProperty(PropertyKey.INGOT) || !material.hasProperty(PropertyKey.GEM)) {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

この条件式は、INGOT または GEM のプロパティのいずれかを持たない場合に真となります。しかし、プルリクエストの目的は「Ingot または Gem を持たないマテリアル」のレシピを修正することであり、これは通常 INGOTGEM の両方を持たないマテリアルを指すと解釈されます。

現在の || (OR) 条件では、INGOT プロパティは持つが GEM プロパティは持たないマテリアル(またはその逆)に対しても、この押し出し機レシピが追加されてしまいます。これにより、既存の stickLong レシピと重複したり、意図しないレシピが追加されたりする可能性があります。

INGOTGEM の両方のプロパティを持たないマテリアルにのみレシピを追加するには、&& (AND) を使用する必要があります。

Suggested change
if (!material.hasProperty(PropertyKey.INGOT) || !material.hasProperty(PropertyKey.GEM)) {
if (!material.hasProperty(PropertyKey.INGOT) && !material.hasProperty(PropertyKey.GEM)) {

@MrKono MrKono merged commit 466c123 into master Apr 24, 2026
2 checks passed
@MrKono MrKono deleted the kono/fixRodRecipe branch April 24, 2026 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant