Skip to content

Add TiC custom traits, stat merging, arrow shaft support, and harvest level extension#7

Merged
tier940 merged 3 commits intomasterfrom
tier-more-tic
Apr 7, 2026
Merged

Add TiC custom traits, stat merging, arrow shaft support, and harvest level extension#7
tier940 merged 3 commits intomasterfrom
tier-more-tic

Conversation

@tier940
Copy link
Copy Markdown
Member

@tier940 tier940 commented Apr 7, 2026

No description provided.

@tier940 tier940 self-assigned this Apr 7, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the integration between GregTech CEu and Tinkers' Construct. It moves away from static material definitions toward a dynamic system that derives traits, stats, and harvest levels directly from GregTech material properties. Additionally, it introduces a robust system for merging stats with existing Tinkers' Construct materials and adds support for advanced tool components like arrow shafts, ensuring a more seamless and feature-rich experience for players using both mods.

Highlights

  • Automated Trait Assignment: Implemented dynamic trait assignment based on GregTech material properties (e.g., blast temperature, durability, attack damage) instead of hardcoded lists.
  • Stat Merging and Support: Added support for merging stats when material names collide with existing Tinkers' Construct materials, and added support for Arrow Shaft stats.
  • Harvest Level Extension: Enabled dynamic registration of harvest levels beyond Cobalt (GT level 5+) to support higher-tier GregTech materials.
  • Enchantment Integration: Added functionality to automatically apply GregTech ToolProperty enchantments as custom Tinkers' Construct traits.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

このプルリクエストは、Tinkers' Constructとの連携機能を大幅に強化し、GregTechの材料特性に基づいたトレイトの自動割り当て、アローシャフトのステータス対応、既存材料とのステータス統合、およびCobaltを超える動的な採掘レベルの登録を導入します。レビューでは、Minecraft 1.12.2(Java 8)環境でJava 14以降のswitch式が使用されている点や、サーバー側でクラッシュを引き起こすクライアント専用のI18nクラスが使用されている点など、互換性に関する重大な問題が指摘されています。

@tier940 tier940 merged commit f8f8bb0 into master Apr 7, 2026
2 checks passed
@tier940 tier940 deleted the tier-more-tic branch April 7, 2026 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant