Skip to content

Add dual-tool mining support for GT + TiC cross-hand combinations#9

Merged
tier940 merged 4 commits intomasterfrom
tier-tic-dual-tool
Apr 8, 2026
Merged

Add dual-tool mining support for GT + TiC cross-hand combinations#9
tier940 merged 4 commits intomasterfrom
tier-tic-dual-tool

Conversation

@tier940
Copy link
Copy Markdown
Member

@tier940 tier940 commented Apr 8, 2026

No description provided.

@tier940 tier940 self-assigned this Apr 8, 2026
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces comprehensive integration between GregTech and Tinkers' Construct, specifically focusing on cross-mod tool usage. By enabling dual-tool mining, players can now utilize the strengths of both systems simultaneously, such as using a Tinkers' tool in the off-hand to assist with mining blocks that a GregTech tool in the main-hand cannot harvest. Additionally, the update expands material registration to better support polymer-based materials and improves overall compatibility through targeted Mixin implementations.

Highlights

  • Dual-Tool Mining Support: Implemented cross-hand mining support between GregTech and Tinkers' Construct tools, allowing for combined harvest levels and mining speeds.
  • Material Integration: Added new registrars for elastic materials and tool stats, enabling better integration of GT polymer materials into the Tinkers' Construct system.
  • Mixin Infrastructure: Introduced several Mixins to handle tool hand-swapping and harvest level elevation, ensuring seamless interaction between the two mod ecosystems.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

このプルリクエストは、GregTech (GT) と Tinkers' Construct (TiC) の連携機能を大幅に拡張するものです。主な変更点として、GTツールとTiCツールを両手に持った際の採掘ロジックが実装され、オフハンド側のツールの性能を適切に反映できるようになりました。また、GTのポリマー素材をTiCの弓弦や羽根素材として自動登録する仕組みや、素材の組成・特性に基づいたTiCトレイトの付与システムが導入されています。フィードバックでは、保守性向上のためのマジックナンバーの定数化、HUD表示の正確性を期すためのツール組み合わせパターンの網羅、およびGTツールの性能をより正確に取得するためのメソッド変更が提案されています。

Comment thread src/main/java/com/github/gtexpert/gtmt/integration/tic/DualToolHandler.java Outdated
@tier940 tier940 merged commit ed39a62 into master Apr 8, 2026
2 checks passed
@tier940 tier940 deleted the tier-tic-dual-tool branch April 8, 2026 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant