This repository was archived by the owner on Sep 5, 2025. It is now read-only.
Merged
Conversation
eigenraven
commented
May 7, 2024
eigenraven
commented
- Remove all unnecessary BigInteger allocations where possible
- Store the fluid types as FluidStacks instead of Strings, this reduces the constant lookups into the fluid registry
- Cache the fluid tank info array
- Big one: only update once per second (20 ticks) instead of every tick, the output fill rate has been bumped 20x to compensate - but bigger input hatches might be needed if they were barely keeping up before.
OneEyeMaker
approved these changes
May 10, 2024
OneEyeMaker
left a comment
OneEyeMaker
left a comment
There was a problem hiding this comment.
Good job!
This PR needs excessive testing to check that moving to per-second ticking scheme doesn't bring any issues.
Dream-Master
pushed a commit
that referenced
this pull request
May 19, 2024
* Clean up yottank biginteger handling code * Only tick the tank once per second, adjust the output to match * Clean up yottahatch and fix a couple of omissions in the tank (cherry picked from commit c22df7b)
58 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.