Merged
Conversation
Collaborator
|
Is this really needed? Short is rarely, almost never used. There is pretty much no point in using it except very minor memory saving. |
Author
|
If you think it's unnecessary I'll remove it. I made this to avoid casting to short a few times in the MTEDebugStructureWriter as it uses shorts for the coordinates and offsets. |
Author
|
Plus there are already syncers for the other value types so why not have this as well? |
2 tasks
brachy84
requested changes
Mar 18, 2026
src/main/java/com/cleanroommc/modularui/value/sync/ShortSyncValue.java
Outdated
Show resolved
Hide resolved
brachy84
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I copied the interfaces and implementations from BooleanSyncValue and IntSyncValue and modified it to fit the short type.
Needed for GTNewHorizons/GT5-Unofficial/pull/6073