Skip to content

Ignore trade nbt#34

Merged
Dream-Master merged 5 commits intomasterfrom
ignore-trade-nbt
Oct 22, 2025
Merged

Ignore trade nbt#34
Dream-Master merged 5 commits intomasterfrom
ignore-trade-nbt

Conversation

@cubefury
Copy link
Copy Markdown
Collaborator

Now ignores NBT for items just like in quest coin exchanges. This is cuz some trades have stuff like minotaur axe, which comes preenchanted when dropped.

  • Items requiring NBT can be placed in either the input slots directly or the ME system.
  • Accounts for item damage still: damaged items don't count
  • Does not affect other trade behaviour, eg. with oredict items, we check that the item can be damaged in the first place

Dev note: I'm not sure if this can be done any more efficiently than pulling the entire contents of the connected ME system every time we need to refresh the interface. I tried using the fuzzy search method on ignore and 99% damage mode, but they both returned nothing, and somehow also ignored exact match items.

image image

@cubefury cubefury requested a review from a team October 19, 2025 09:24
Copy link
Copy Markdown
Member

@FrostyFire1 FrostyFire1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work fine in fullpack

@Dream-Master Dream-Master merged commit 7248eaa into master Oct 22, 2025
1 check passed
@Dream-Master Dream-Master deleted the ignore-trade-nbt branch October 22, 2025 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants