Skip to content

some changes#88

Merged
Ranzuu merged 1 commit intoRanzu/Stylingfrom
styling-changes
Apr 22, 2026
Merged

some changes#88
Ranzuu merged 1 commit intoRanzu/Stylingfrom
styling-changes

Conversation

@cubefury
Copy link
Copy Markdown
Collaborator

Proposed changes:

  1. The initial list item height was correct, just had to extend the rectangles drawn down by 1px. Changing the list item height to 15 caused all the elements to be rendered off-center. I reverted list height to 14 and then extending the draw rect down by 1px instead.
  2. I don't believe we need the GL11 calls (please correct me if I'm wrong on this, just from my testing I dont think it's necessary)
  3. Removed unused trade_disabled texture (was not part of your changes but I realized there wasn't even a png associated with it lmao)
  4. Restored adaptable() methods on textures where applicable: we need these in case the element sizes are changed in the future. It allows us to resize the elements without having to remake the textures. In this sense the textures actually don't need to be bigger than (adaptable2+1, adaptable2+1) pixels in size, but we can leave the textures as they are for now.
  5. Removed alpha channel on trade_display_text_color, and removed two fields which are now unused as we took out the rounded rect draw call that used them.
  6. Resized highlights to ensure that green tradeable highlights are still visible when mouseover-ing a trade.

@Ranzuu Ranzuu merged commit d6fb254 into Ranzu/Styling Apr 22, 2026
@Ranzuu Ranzuu deleted the styling-changes branch April 22, 2026 15:10
cubefury added a commit that referenced this pull request Apr 22, 2026
* Refactor styling
- remove unused trade_available.png  + code
- add new asset (tile_cooldown) - because drawing with the drawRoundedRect was breaking half pixels
- refactor theme to be gt standard (tabs/right panel)
- add new color enum (trade_display_text_color)
- change assets to be static
- in/out icons from other pr

* optimizing images (#87)

Co-authored-by: Ranzu <66495944+Ranzuu@users.noreply.github.com>

* some changes (#88)

* optimizing images (#89)

Co-authored-by: Ranzu <66495944+Ranzuu@users.noreply.github.com>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Martin Robertz <dream-master@gmx.net>
Co-authored-by: cubefury <shuiherng.quek@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants