Skip to content

refactor(storePayment): 결제 연동 기능 구현#187

Merged
Jjiggu merged 1 commit into
developfrom
feature/#186-payment-crud
Jul 29, 2025
Merged

refactor(storePayment): 결제 연동 기능 구현#187
Jjiggu merged 1 commit into
developfrom
feature/#186-payment-crud

Conversation

@Jjiggu
Copy link
Copy Markdown
Contributor

@Jjiggu Jjiggu commented Jul 29, 2025

작업 요약

  • 결제 연동 기능 CRUD 구현

Issue Link

#186

문제점 및 어려움

해결 방안

Reference

Summary by CodeRabbit

  • 신규 기능

    • 결제 정보에 계좌번호(accountNumber) 필드가 추가되었습니다. 이제 결제 등록, 조회, 수정 시 계좌번호 정보를 입력 및 확인할 수 있습니다.
  • 버그 수정

    • 결제 URL 및 계좌번호가 없는 경우 응답에서 빈 문자열로 반환되도록 개선되었습니다.
  • 문서화

    • 결제 정보 생성 API의 설명이 보다 명확하게 수정되었습니다.

@Jjiggu Jjiggu self-assigned this Jul 29, 2025
@Jjiggu Jjiggu added enhancement New feature or request refactor 리팩토링 labels Jul 29, 2025
@Jjiggu Jjiggu merged commit d40c7c8 into develop Jul 29, 2025
1 check passed
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jul 29, 2025

Warning

Rate limit exceeded

@Jjiggu has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 16 minutes and 20 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 11a17a8 and 0f6e636.

📒 Files selected for processing (7)
  • nowait-app-admin-api/src/main/java/com/nowait/applicationadmin/storePayment/controller/StorePaymentController.java (1 hunks)
  • nowait-app-admin-api/src/main/java/com/nowait/applicationadmin/storePayment/dto/StorePaymentCreateRequest.java (1 hunks)
  • nowait-app-admin-api/src/main/java/com/nowait/applicationadmin/storePayment/dto/StorePaymentCreateResponse.java (1 hunks)
  • nowait-app-admin-api/src/main/java/com/nowait/applicationadmin/storePayment/dto/StorePaymentReadDto.java (2 hunks)
  • nowait-app-admin-api/src/main/java/com/nowait/applicationadmin/storePayment/dto/StorePaymentUpdateRequest.java (1 hunks)
  • nowait-app-admin-api/src/main/java/com/nowait/applicationadmin/storePayment/service/StorePaymentServiceImpl.java (1 hunks)
  • nowait-domain/domain-core-rdb/src/main/java/com/nowait/domaincorerdb/storePayment/entity/StorePayment.java (1 hunks)

Walkthrough

이 변경 사항은 주점 결제 정보 관리 기능에 계좌번호(accountNumber) 필드를 추가하고, 관련 DTO, 엔티티, 서비스 레이어를 수정합니다. 또한 API 문서의 설명이 일부 변경되었습니다. 기존 결제 URL 필드와 함께 계좌번호가 생성, 조회, 수정 요청 및 응답에 포함됩니다.

Changes

Cohort / File(s) Change Summary
컨트롤러 문서화
nowait-app-admin-api/src/main/java/com/nowait/applicationadmin/storePayment/controller/StorePaymentController.java
createStorePayment 엔드포인트의 Swagger 문서 summary 텍스트만 변경됨. 코드 로직은 변경 없음.
생성 요청 DTO
nowait-app-admin-api/src/main/java/com/nowait/applicationadmin/storePayment/dto/StorePaymentCreateRequest.java
accountNumber 필드 추가 및 toEntity에서 해당 필드 설정 추가.
생성 응답 DTO
nowait-app-admin-api/src/main/java/com/nowait/applicationadmin/storePayment/dto/StorePaymentCreateResponse.java
accountNumber 필드 추가, URL 및 계좌번호 필드가 null일 경우 빈 문자열로 반환하도록 변경.
조회 DTO
nowait-app-admin-api/src/main/java/com/nowait/applicationadmin/storePayment/dto/StorePaymentReadDto.java
accountNumber 필드 추가 및 fromEntity에서 해당 필드 설정 추가.
수정 요청 DTO
nowait-app-admin-api/src/main/java/com/nowait/applicationadmin/storePayment/dto/StorePaymentUpdateRequest.java
accountNumber 필드 추가.
서비스 구현
nowait-app-admin-api/src/main/java/com/nowait/applicationadmin/storePayment/service/StorePaymentServiceImpl.java
updateStorePayment에서 updatePaymentMethodUrl 호출 시 accountNumber 전달 추가.
엔티티 및 도메인
nowait-domain/domain-core-rdb/src/main/java/com/nowait/domaincorerdb/storePayment/entity/StorePayment.java
accountNumber 컬럼 및 필드 추가, 생성자와 updatePaymentMethodUrl에 해당 파라미터 추가, 일부 컬럼 nullable 명시.

Sequence Diagram(s)

sequenceDiagram
    participant Client
    participant Controller
    participant Service
    participant Entity

    Client->>Controller: createStorePayment(accountNumber, tossUrl, ...)
    Controller->>Service: createStorePayment(request)
    Service->>Entity: StorePayment 생성 (accountNumber, tossUrl, ...)
    Entity-->>Service: StorePayment 객체 반환
    Service-->>Controller: StorePaymentCreateResponse(accountNumber, tossUrl, ...)
    Controller-->>Client: 응답 반환
Loading
sequenceDiagram
    participant Client
    participant Controller
    participant Service
    participant Entity

    Client->>Controller: updateStorePayment(accountNumber, tossUrl, ...)
    Controller->>Service: updateStorePayment(request)
    Service->>Entity: updatePaymentMethodUrl(accountNumber, tossUrl, ...)
    Entity-->>Service: 업데이트 완료
    Service-->>Controller: 완료 응답
    Controller-->>Client: 응답 반환
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~15–20 minutes

Suggested reviewers

  • HyemIin
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feature/#186-payment-crud

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions Bot requested a review from HyemIin July 29, 2025 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request refactor 리팩토링

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant