Refoctor: 주문 내역 조회 날짜 필터링 추가#249
Merged
Merged
Conversation
|
Caution Review failedThe pull request is closed. Walkthrough이번 변경 사항은 주문 조회 API의 반환 범위와 문서화, 그리고 CORS 설정을 수정합니다. 주문 서비스는 이제 당일 생성된 주문만 반환하도록 내부 로직과 쿼리가 변경되었으며, 이에 따라 레포지토리 메서드 시그니처도 수정되었습니다. 추가로, 일부 문서화 및 코드 포맷팅, CORS 허용 도메인 목록이 조정되었습니다. Changes
Sequence Diagram(s)sequenceDiagram
participant AdminAPI as OrderController
participant OrderService
participant OrderRepository
participant DB
AdminAPI->>OrderService: findAllOrders(storeId, memberDetails)
OrderService->>OrderService: 오늘 날짜의 시작/끝 계산 (Asia/Seoul)
OrderService->>OrderRepository: findAllByStore_StoreIdAndCreatedAtBetween(storeId, start, end)
OrderRepository->>DB: 쿼리 (storeId, createdAt between start and end)
DB-->>OrderRepository: 주문 목록 반환
OrderRepository-->>OrderService: 주문 목록 반환
OrderService-->>AdminAPI: 주문 목록 반환
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10분 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (5)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
작업 요약
Issue Link
#248
문제점 및 어려움
해결 방안
Reference
Summary by CodeRabbit
버그 수정
기타