Skip to content

Conversation

@oriNuguri25
Copy link
Collaborator

@oriNuguri25 oriNuguri25 commented Sep 2, 2025

작업 내용

문제점 및 어려움

해결 방안

공유 사항

Summary by CodeRabbit

  • New Features
    • Tap/click “조리 중” orders to open a detail overlay on mobile and desktop.
    • Review order info and complete cooking via a dedicated confirmation modal.
    • Preserves and restores scroll position when opening/closing the overlay for smoother navigation.
    • Automatically clears overlays when switching tabs/statuses to avoid stale views.
    • Uses consistent time formatting across detail overlays for improved readability.

@coderabbitai
Copy link

coderabbitai bot commented Sep 2, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Adds a “cooking” detail overlay flow: clickable cooking cards open a DetailCard overlay; a new modal handles “cook complete.” State tracks selected cooking order and scroll position, with open/close handlers across desktop/mobile layouts. DetailCard supports type="cooking" and uses CookCompleteModal. CookCard now accepts an optional onClick.

Changes

Cohort / File(s) Summary of Changes
Cooking overlay workflow
apps/nowait-admin/src/pages/AdminOrders/AdminOrders.tsx, apps/nowait-admin/src/pages/AdminOrders/DetailCard.tsx, apps/nowait-admin/src/pages/AdminOrders/OrderCard.tsx
- AdminOrders: add selectedCooking state, click handler to open cooking overlay, close handler restoring scroll, reset on tab/status change, layout tweaks to host overlay, render DetailCard type="cooking".
- DetailCard: extend DetailType with "cooking", configure labels/action, use CookCompleteModal with reduced props for cooking, keep other types unchanged.
- OrderCard: add optional onClick to CookCard and wire to root (cursor-pointer).

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User
  participant CookCard (List)
  participant AdminOrders (Page)
  participant DetailCard (Overlay)
  participant CookCompleteModal (Modal)
  participant API

  User->>CookCard (List): Click cooking order
  CookCard (List)->>AdminOrders (Page): onClick()
  AdminOrders (Page)->>AdminOrders (Page): Save scroll, set selectedCooking, scrollToTop
  AdminOrders (Page)->>DetailCard (Overlay): Render type="cooking" with orderId...

  User->>DetailCard (Overlay): Click "조리 완료"
  DetailCard (Overlay)->>CookCompleteModal (Modal): Open
  User->>CookCompleteModal (Modal): Confirm
  CookCompleteModal (Modal)->>API: POST cook complete
  API-->>CookCompleteModal (Modal): Success/Failure

  CookCompleteModal (Modal)-->>DetailCard (Overlay): onSuccess / onClose
  DetailCard (Overlay)->>AdminOrders (Page): onSuccess / onClose
  AdminOrders (Page)->>AdminOrders (Page): Clear selectedCooking, restore scroll
Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Suggested reviewers

  • dgKim1

Poem

A whisk of code, a simmering view,
Cards go click—an overlay anew.
Modal bubbles, “Cook complete!”—hooray!
I twitch my ears and hop away.
Orders plated, backlog light—
A happy rabbit ships tonight. 🥕✨


📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 469bcb0 and e9dcac6.

📒 Files selected for processing (3)
  • apps/nowait-admin/src/pages/AdminOrders/AdminOrders.tsx (10 hunks)
  • apps/nowait-admin/src/pages/AdminOrders/DetailCard.tsx (3 hunks)
  • apps/nowait-admin/src/pages/AdminOrders/OrderCard.tsx (2 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@oriNuguri25 oriNuguri25 merged commit c06c248 into main Sep 2, 2025
2 of 3 checks passed
@github-actions github-actions bot requested a review from hwangdae September 2, 2025 08:37
This was referenced Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants