Remove from_json and to_json in Gigamonkey::Bitcoin. MatterPoolAPI is now MatterPool::API#2
Merged
GaeaKat merged 2 commits intoGaeaKat:mainfrom Apr 13, 2021
Gigamonkey-BSV:header
Merged
Remove from_json and to_json in Gigamonkey::Bitcoin. MatterPoolAPI is now MatterPool::API#2GaeaKat merged 2 commits intoGaeaKat:mainfrom Gigamonkey-BSV:header
GaeaKat merged 2 commits intoGaeaKat:mainfrom
Gigamonkey-BSV:header
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Functions from_json and to_json were here in namespace Gigamonkey::Bitcoin. The problem with this is that bitcoin headers do not have a defined json representation. Gigamonkey::Bitcoin::header is supposed to be just a Bitcoin header, not anything else. Potentially, a different API we use could use a different json representation. Some particular json representation shouldn't be associated with this type.
I have solved this by creating a Cosmos::MatterPool namespace with a type Header that inherents from Gigamonkey::Bitcoin::headers and also has from_json and to_json.
MatterPoolApi is now MatterPool::api and MatterPool_Timechain is now MatterPool::Timechain