Syntax formatter v1 v2#1492
Merged
borisbat merged 3 commits intoFeb 5, 2025
Merged
Conversation
aleksisch
force-pushed
the
syntax-formatter-v1-v2
branch
2 times, most recently
from
028af80 to
084878c
Compare
aleksisch
force-pushed
the
syntax-formatter-v1-v2
branch
from
084878c to
2b088c9
Compare
aleksisch
commented
Feb 4, 2025
| <normal>\$t([^a-zA-Z0-9_]) unput(yytext[yyleng-1]); return MTAG_T; | ||
| <normal>\$c([^a-zA-Z0-9_]) unput(yytext[yyleng-1]); return MTAG_C; | ||
| <normal>\$f([^a-zA-Z0-9_]) unput(yytext[yyleng-1]); return MTAG_F; | ||
| <normal>\$e([^a-zA-Z0-9_]) unput(yytext[yyleng-1]); YYCOLUMN(yyextra->das_yycolumn--, "UNPUT $"); return MTAG_E; |
Collaborator
Author
There was a problem hiding this comment.
I'm not sure about lexer part. But looks like it fixes incorrect location. Also, sometimes in other cases we do it on unput()
aleksisch
force-pushed
the
syntax-formatter-v1-v2
branch
3 times, most recently
from
36bb1da to
d7e519e
Compare
aleksisch
force-pushed
the
syntax-formatter-v1-v2
branch
from
d7e519e to
8212e5a
Compare
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR creates tool to transform from syntax v1 to syntax v2.
Main logic are in second commit.
Right now there's one problem:
we'll lose all comments and spaces/linebreak inside initialization expression: