Fix some parsing issues with complex truth catalog entries#1083
Merged
Conversation
Member
Author
|
@NiallMac Do you mind taking a look at this? I think it solves all of the problems you'd been having with the truth field. You don't have to check the implementation, but if you can at least look at the unit tests and make sure I hit all the things we tried that we thought should have worked but didn't, that would be much appreciated. |
Member
Author
|
Any objection to merging this? I have more config-layer work I've been working on, so I'd like these changes to get onto master before that PR. I'll merge Friday unless I hear that anyone wants more time to review this. |
2955d9c to
6157fef
Compare
…or np.integer types
…fter @gal.index
…e more hints to the user.
6157fef to
4a84f9a
Compare
Contributor
|
Sorry for the delay on this Mike, just got to it now. The expanded unit test looks great to me. |
…d to check if _bar
… it wrong for some reason.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@NiallMac was having some problems getting some values into the truth catalog for DES runs. We eventually found a workaround, but this PR fixes the underlying issues to make it easier to get these kinds of items parsed properly.
cf. https://github.com/des-science/y3-wl_image_sims/issues/82
Specifically, I've made the following changes: