Skip to content

feat: update for coord 1.4 and point tests at main branch#110

Merged
beckermr merged 4 commits intomainfrom
coord-submod
Aug 21, 2024
Merged

feat: update for coord 1.4 and point tests at main branch#110
beckermr merged 4 commits intomainfrom
coord-submod

Conversation

@beckermr
Copy link
Collaborator

This PR updates the submodule for Coord to point at the main branch.

@codspeed-hq
Copy link

codspeed-hq bot commented Aug 21, 2024

CodSpeed Performance Report

Merging #110 will degrade performances by 11.78%

Comparing coord-submod (18ed77e) with main (b8b7387)

Summary

⚡ 1 improvements
❌ 2 (👁 2) regressions
✅ 8 untouched benchmarks

Benchmarks breakdown

Benchmark main coord-submod Change
test_benchmarks_lanczos_interp[kval-no_conserve_dc-run] 647.5 µs 447.1 µs +44.82%
👁 test_benchmarks_lanczos_interp[xval-conserve_dc-run] 779.8 µs 879.7 µs -11.36%
👁 test_benchmarks_lanczos_interp[xval-no_conserve_dc-run] 732.9 µs 830.8 µs -11.78%

@beckermr beckermr changed the title feat: update coord to point at main feat: update for coord 1.4 and point tests at main branch Aug 21, 2024
@beckermr beckermr marked this pull request as ready for review August 21, 2024 16:08
@beckermr
Copy link
Collaborator Author

@ismael-mendoza this one is ready for review!

@ismael-mendoza ismael-mendoza self-assigned this Aug 21, 2024
@ismael-mendoza ismael-mendoza self-requested a review August 21, 2024 17:12
@ismael-mendoza
Copy link
Collaborator

thanks @beckermr will take a look sometime this afternoon

Copy link
Collaborator

@ismael-mendoza ismael-mendoza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beckermr beckermr merged commit 16b9ae0 into main Aug 21, 2024
@beckermr beckermr deleted the coord-submod branch August 21, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants