Conversation
beckermr
reviewed
Feb 7, 2026
Co-authored-by: Matthew R. Becker <beckermr@users.noreply.github.com>
beckermr
approved these changes
Feb 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims for minimal edits allowing for jax version update. With this update, we can reach the latest jax 0.8 version, quadax prevents us from going to jax v0.9.
TFP is apparentently no longer releasing new versions, but tfp-nightly continues to be maintained for new jax releases. We should still ultimately remove TFP because it's only used for this very speicific Bessel function, and it prevents installs on python 3.13, but for now this would be an easy fix and we can then compare the code speed before and after changing the bessel function implementation on same version of jax.
I left the tfp-nighlty version unconstrained, it should automatically adjust to the jax version, which in turn will be the latest version permitted by quadrax.