Skip to content

Quantify: part 1#136

Merged
nstarman merged 7 commits intoGalacticDynamics:mainfrom
nstarman:quantify
Feb 10, 2024
Merged

Quantify: part 1#136
nstarman merged 7 commits intoGalacticDynamics:mainfrom
nstarman:quantify

Conversation

@nstarman
Copy link
Contributor

@nstarman nstarman commented Feb 9, 2024

New dependencies:

  • array-api-jax-compat
  • jax-quantity

Code changes:

  • Quantifies shape utils.

@nstarman nstarman added this to the v0.1 milestone Feb 9, 2024
@GalacticDynamics GalacticDynamics deleted a comment from codecov bot Feb 9, 2024
@nstarman nstarman force-pushed the quantify branch 4 times, most recently from 6e359f8 to 247b7a9 Compare February 10, 2024 06:34
@GalacticDynamics GalacticDynamics deleted a comment from codecov bot Feb 10, 2024
@nstarman nstarman force-pushed the quantify branch 2 times, most recently from 05382fa to 02eca93 Compare February 10, 2024 19:41
@nstarman nstarman changed the title Quantify Quantify: part 1 Feb 10, 2024
@nstarman nstarman marked this pull request as ready for review February 10, 2024 19:42
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Feb 10, 2024

Codecov Report

Attention: 11 lines in your changes are missing coverage. Please review.

Comparison is base (c972652) 88.44% compared to head (52e5a85) 88.50%.
Report is 8 commits behind head on main.

Files Patch % Lines
...amics/_dynamics/mockstream/mockstream_generator.py 73.68% 5 Missing ⚠️
src/galax/dynamics/_dynamics/orbit.py 84.00% 4 Missing ⚠️
src/galax/potential/_potential/base.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #136      +/-   ##
==========================================
+ Coverage   88.44%   88.50%   +0.05%     
==========================================
  Files          42       45       +3     
  Lines        1324     1383      +59     
==========================================
+ Hits         1171     1224      +53     
- Misses        153      159       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nstarman nstarman merged commit 635c07d into GalacticDynamics:main Feb 10, 2024
@nstarman nstarman deleted the quantify branch February 10, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant