Skip to content

feat: use rng in mockstream#208

Merged
nstarman merged 4 commits intoGalacticDynamics:mainfrom
nstarman:mockgen-rng
Mar 13, 2024
Merged

feat: use rng in mockstream#208
nstarman merged 4 commits intoGalacticDynamics:mainfrom
nstarman:mockgen-rng

Conversation

@nstarman
Copy link
Contributor

Ping @jnibauer. I think there are further improvements to be made, e.g. I think we can iterate over the rng rather than evolve it within the scan, but this is for a followup.

Signed-off-by: nstarman <nstarman@users.noreply.github.com>
@nstarman nstarman added this to the v0.1 milestone Mar 12, 2024
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
Signed-off-by: nstarman <nstarman@users.noreply.github.com>
@codecov
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 89.66%. Comparing base (c972652) to head (a39517c).
Report is 62 commits behind head on main.

Files Patch % Lines
...amics/_dynamics/mockstream/mockstream_generator.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #208      +/-   ##
==========================================
+ Coverage   88.44%   89.66%   +1.22%     
==========================================
  Files          42       54      +12     
  Lines        1324     1829     +505     
==========================================
+ Hits         1171     1640     +469     
- Misses        153      189      +36     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nstarman nstarman marked this pull request as ready for review March 13, 2024 13:27
@nstarman nstarman merged commit e1080e5 into GalacticDynamics:main Mar 13, 2024
@nstarman nstarman deleted the mockgen-rng branch March 13, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant