Skip to content

Conversation

@Galarzaa90
Copy link
Owner

Changes

  • Parsing Highscores from Tibia.com and TibiaData.
  • Some strings from TibiaData had unpredictable trailing whitespaces,
    all leading and trailing whitespaces are removed.
  • Added type hints to many variables and methods.

@codecov-io
Copy link

codecov-io commented Jan 9, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@84df1bb). Click here to learn what that means.
The diff coverage is 98.51%.

Impacted file tree graph

@@           Coverage Diff            @@
##             master      #8   +/-   ##
========================================
  Coverage          ?   98.7%           
========================================
  Files             ?      10           
  Lines             ?    1387           
  Branches          ?       0           
========================================
  Hits              ?    1369           
  Misses            ?      18           
  Partials          ?       0
Impacted Files Coverage Δ
tibiapy/house.py 99.06% <100%> (ø)
tibiapy/world.py 98.19% <100%> (ø)
tibiapy/guild.py 99.09% <100%> (ø)
tibiapy/utils.py 100% <100%> (ø)
tibiapy/character.py 98.11% <100%> (ø)
tibiapy/__init__.py 100% <100%> (ø)
tibiapy/enums.py 100% <100%> (ø)
tibiapy/highscores.py 96.66% <96.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 84df1bb...e5908a8. Read the comment docs.

@Galarzaa90 Galarzaa90 merged commit 0455d39 into master Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants