Skip to content

feat(bls_precompile): add benchmark and raise POP_VERIFY_GAS to 110k#283

Merged
nekomoto911 merged 3 commits intoGalxe:mainfrom
nekomoto911:fix/pop_verify_gas
Mar 10, 2026
Merged

feat(bls_precompile): add benchmark and raise POP_VERIFY_GAS to 110k#283
nekomoto911 merged 3 commits intoGalxe:mainfrom
nekomoto911:fix/pop_verify_gas

Conversation

@nekomoto911
Copy link
Copy Markdown
Collaborator

  • Add criterion benchmark (benches/bls_pop_verify_bench.rs) with 4 scenarios: valid pop, invalid pop, invalid pubkey, and full handler path
  • Raise POP_VERIFY_GAS from 45,000 to 110,000 based on benchmark data: ~2.16ms per call, aligned with EIP-2537 BLS pairing (2 pairs) pricing
  • Make verify_pop and bls_pop_verify_handler_raw pub for bench access

- Add criterion benchmark (benches/bls_pop_verify_bench.rs) with 4 scenarios:
  valid pop, invalid pop, invalid pubkey, and full handler path
- Raise POP_VERIFY_GAS from 45,000 to 110,000 based on benchmark data:
  ~2.16ms per call, aligned with EIP-2537 BLS pairing (2 pairs) pricing
- Make verify_pop and bls_pop_verify_handler_raw pub for bench access
Copy link
Copy Markdown
Collaborator

@Richard1048576 Richard1048576 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nekomoto911 nekomoto911 merged commit 47813d7 into Galxe:main Mar 10, 2026
30 checks passed
@nekomoto911 nekomoto911 deleted the fix/pop_verify_gas branch March 10, 2026 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants