fix: audit round 3#284
Merged
nekomoto911 merged 5 commits intoGalxe:mainfrom Mar 10, 2026
Merged
Conversation
Collaborator
nekomoto911
commented
Mar 9, 2026
nekomoto911
commented
- Replace type-erased event bus with typed OnceLock
- Remove the duplicate new_system_call_txn() in metadata_txn.rs
- Add design-intent comments for epoch/execute_height atomic ordering
- Replace OnceCell<Box<dyn Any>> with OnceLock<PipeExecLayerEventBus<EthPrimitives>> - Remove generic parameter from get_pipe_exec_layer_event_bus() - Add 120s timeout with panic on expiry (GRETH-038 combined fix) - Add TypeId assertion in tree/mod.rs pipe_run_inner as runtime safety guard - Use transmute to bridge Receiver<PipeExecLayerEvent<EthPrimitives>> to generic N - Update all call sites to remove turbofish generic parameter
nekomoto911
force-pushed
the
fix/audit-round-3
branch
from
4035659 to
de5ab1e
Compare
Ketooooooo
approved these changes
Mar 10, 2026
Lchangliang
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.