fix(unwind): commit view and set prune distance for execution unwind#313
Merged
AshinGau merged 2 commits intoGalxe:mainfrom Mar 30, 2026
Merged
fix(unwind): commit view and set prune distance for execution unwind#313AshinGau merged 2 commits intoGalxe:mainfrom
AshinGau merged 2 commits intoGalxe:mainfrom
Conversation
AshinGau
force-pushed
the
main
branch
3 times, most recently
from
80f64d6 to
fd932b3
Compare
Lchangliang
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix unwind in pipe execution mode with two key changes:
Prune safety distance: Enforce MINIMUM_PRUNING_DISTANCE gap in get_next_block_range() so the pruner always retains enough historical blocks for unwind, preventing missing data errors.
RocksDB commit view: Insert commit_view() calls between write and read steps during unwind. Unlike MDBX, RocksDB's WriteBatch doesn't provide immediate read-after-write visibility within a transaction, so explicit flushes are needed before state root recalculation and state removal can read the updated data.
Also includes: moving nested_hash to reth-trie-db for reuse, skipping init_genesis on already-initialized databases, and minor logging improvements.