Conversation
… patches Previously, `EvmStorageSlot::new_changed` hardcoded `U256::ZERO` as the original_value for all storage patches. If a patched slot previously held a non-zero value, unwind/revert would incorrectly restore it to zero instead of its true prior value. Read the current slot value from state via `DatabaseRef::storage_ref` before constructing the storage slot. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ByteYue
force-pushed
the
fix/hardfork-storage-patch-original-value
branch
from
70d1498 to
3daf876
Compare
AshinGau
approved these changes
Apr 8, 2026
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
U256::ZEROasoriginal_valueinEvmStorageSlot::new_changedfor bothstorage_patchesandbatch_storage_patchesDatabaseRef::storage_refbefore constructing the storage slot, ensuring correct unwind/revert behavior when patched slots hold non-zero valuesCloses Galxe/gravity-audit#1
Test plan
cargo check -p reth-evm-ethereumpasses🤖 Generated with Claude Code