Conversation
ByteYue
approved these changes
Apr 24, 2026
Follows Galxe/gravity-aptos#72 which introduced Identity::FromGcpSecret and InitialSafetyRulesConfig::FromGcpSecret on the aptos-node branch. The gravity-sdk consumers import ConfigStorage from gaptos (which will bump to this same aptos-node tip in the companion sdk PR). Without this bump, greth ends up with api-types @ 1d1153b6fd while sdk's gaptos would be at the post-merge aptos-node tip — cargo sees two distinct api-types packages keyed by source rev, and the impl of `ConfigStorage for PipeExecLayerApi` here no longer resolves against sdk's imported ConfigStorage trait (fails with E0599 'fetch_config_bytes not found'). api-types contents are unchanged between 1d1153b6fd and e9544c8cb3 — the three intermediate commits only touch aptos-config/config/ (adds the GCP Secret Manager identity variants behind an off-by-default cargo feature). This bump is a pure version alignment, no behavior change in greth. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
3665c75 to
5e99fb7
Compare
nekomoto911
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps the
gravity-api-types(aliasedapi-types) pin from the stale1d1153b6fdtoe9544c8cb3d8a5757d4c7f1b4807b312c03ba060— the post-merge tip ofaptos-nodeafter Galxe/gravity-aptos#72.Why this is needed
Follows Galxe/gravity-aptos#72 which introduced
Identity::FromGcpSecretandInitialSafetyRulesConfig::FromGcpSecreton theaptos-nodebranch. Downstreamgravity-sdkwill bump itsgaptosrev to this same aptos-node tip in the companion PR Galxe/gravity-sdk#688.Without this bump, greth ends up with
api-types @ 1d1153b6fdwhile sdk'sgaptospullsapi-types @ e9544c8cb3. Cargo identifies packages by(name, source_url, rev)— two distinct rev SHAs = two distinct packages in the resolved graph. Theimpl ConfigStorage for PipeExecLayerApidefined in this crate (crates/pipe-exec-layer-ext-v2/execute/src/lib.rs) would then be keyed to greth's copy of theConfigStoragetrait, while sdk'suse gaptos::api_types::config_storage::ConfigStorageimports gaptos's copy. Method lookups fail with:What changes in greth
Nothing behaviorally.
api-typessubcrate contents are byte-identical between1d1153b6fdande9544c8cb3— the three intermediate commits only touchaptos-config/config/(adds theFromGcpSecretenum variants behind an off-by-default cargo featuregcp-secret-manager). This is pure dep-version alignment.Test plan
cargo build -p reth-pipe-exec-layer-ext-v2locally (verified during pilot, greth-side impls compile unchanged)cargo checkpass after both this and gravity-aptos#72 are mergedMerge ordering
gaptostoe9544c8cb3andgrethto this PR's merge SHA)🤖 Generated with Claude Code