Skip to content

chore(deps): bump gravity-api-types to aptos-node tip (e9544c8cb3)#336

Merged
keanji-x merged 1 commit intomainfrom
chore/bump-api-types-for-gcp-secret-manager
Apr 25, 2026
Merged

chore(deps): bump gravity-api-types to aptos-node tip (e9544c8cb3)#336
keanji-x merged 1 commit intomainfrom
chore/bump-api-types-for-gcp-secret-manager

Conversation

@keanji-x
Copy link
Copy Markdown
Collaborator

Summary

Bumps the gravity-api-types (aliased api-types) pin from the stale 1d1153b6fd to e9544c8cb3d8a5757d4c7f1b4807b312c03ba060 — the post-merge tip of aptos-node after Galxe/gravity-aptos#72.

Why this is needed

Follows Galxe/gravity-aptos#72 which introduced Identity::FromGcpSecret and InitialSafetyRulesConfig::FromGcpSecret on the aptos-node branch. Downstream gravity-sdk will bump its gaptos rev to this same aptos-node tip in the companion PR Galxe/gravity-sdk#688.

Without this bump, greth ends up with api-types @ 1d1153b6fd while sdk's gaptos pulls api-types @ e9544c8cb3. Cargo identifies packages by (name, source_url, rev) — two distinct rev SHAs = two distinct packages in the resolved graph. The impl ConfigStorage for PipeExecLayerApi defined in this crate (crates/pipe-exec-layer-ext-v2/execute/src/lib.rs) would then be keyed to greth's copy of the ConfigStorage trait, while sdk's use gaptos::api_types::config_storage::ConfigStorage imports gaptos's copy. Method lookups fail with:

error[E0599]: no method named `fetch_config_bytes` found for struct
              `PipeExecLayerApi<Storage, EthApi>` in the current scope
help: trait `ConfigStorage` which provides `fetch_config_bytes` is implemented
      but not in scope; perhaps you want to import it

What changes in greth

Nothing behaviorally. api-types subcrate contents are byte-identical between 1d1153b6fd and e9544c8cb3 — the three intermediate commits only touch aptos-config/config/ (adds the FromGcpSecret enum variants behind an off-by-default cargo feature gcp-secret-manager). This is pure dep-version alignment.

Test plan

  • cargo build -p reth-pipe-exec-layer-ext-v2 locally (verified during pilot, greth-side impls compile unchanged)
  • CI green on this PR
  • Downstream: gravity-sdk#688 rebuild and cargo check pass after both this and gravity-aptos#72 are merged

Merge ordering

  1. feat(config): load identity blob from GCP Secret Manager gravity-aptos#72 ✅ (already merged)
  2. This PR (ideally rebase/fast-forward to keep a clean tip SHA for the downstream pin)
  3. feat(cluster): support GCP Secret Manager as identity source gravity-sdk#688 (bumps gaptos to e9544c8cb3 and greth to this PR's merge SHA)

🤖 Generated with Claude Code

Follows Galxe/gravity-aptos#72 which introduced Identity::FromGcpSecret
and InitialSafetyRulesConfig::FromGcpSecret on the aptos-node branch.

The gravity-sdk consumers import ConfigStorage from gaptos (which will
bump to this same aptos-node tip in the companion sdk PR). Without this
bump, greth ends up with api-types @ 1d1153b6fd while sdk's gaptos
would be at the post-merge aptos-node tip — cargo sees two distinct
api-types packages keyed by source rev, and the impl of
`ConfigStorage for PipeExecLayerApi` here no longer resolves against
sdk's imported ConfigStorage trait (fails with E0599
'fetch_config_bytes not found').

api-types contents are unchanged between 1d1153b6fd and e9544c8cb3 —
the three intermediate commits only touch aptos-config/config/ (adds
the GCP Secret Manager identity variants behind an off-by-default
cargo feature). This bump is a pure version alignment, no behavior
change in greth.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@keanji-x keanji-x force-pushed the chore/bump-api-types-for-gcp-secret-manager branch from 3665c75 to 5e99fb7 Compare April 24, 2026 16:00
@keanji-x keanji-x merged commit f9b10b4 into main Apr 25, 2026
32 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants