Merged
Conversation
keanji-x
added a commit
that referenced
this pull request
Apr 14, 2026
- #62: Fix infinite loop in `push_bucket_to_batches` when an oversized transaction (exceeding `sender_max_batch_bytes`) heads the queue. The oversized tx is now skipped with a warning instead of spinning forever. - #54: Handle persist-phase errors in `buffer_manager` tokio::select!. Previously `Some(Err(_))` was silently consumed; now it is logged so operators can diagnose pipeline stalls. - #55: Add 30-second timeout to `BufferManager::reset()` spin loop. Prevents permanent deadlock if a task is leaked and `ongoing_tasks` never reaches zero. - #65: Replace `.expect()` on channel sends in quorum store `network_listener` with graceful error handling. A dropped receiver now logs an error and breaks the loop instead of panic-cascading across all quorum store components. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
3 tasks
keanji-x
added a commit
that referenced
this pull request
Apr 14, 2026
The error logging fix for #54 prevents silent error consumption, but the pipeline can still stall because committed blocks are already popped from the buffer. Add a TODO noting that a pipeline reset should be considered for full recovery. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.