Several minor fixes for the cmake system#584
Merged
ChrisJChang merged 1 commit intomasterfrom Apr 30, 2026
Merged
Conversation
Real bugs fixed
- cmake/warnings.cmake: set_compiler_warning("error") now passes CMAKE_CXX_FLAGS so -DWERROR=ON actually adds -Werror.
- cmake/optional.cmake: ${CoulourReset} typo corrected to ${ColourReset} in the C-MPI-without-C++-MPI warning.
Better error/help messages
- CMakeLists.txt: minimum-compiler FATAL_ERROR now mentions clang++ and AppleClang minimums alongside g++ and icpc.
- CMakeLists.txt: Eigen3 FATAL_ERROR now points users at -DEIGEN3_INCLUDE_DIR=/path/... and the EIGEN3_ROOT env var as alternatives to
installing.
- cmake/optional.cmake: ROOT path now distinguishes ROOTSYS unset (suggests sourcing thisroot.sh) from "found ROOTSYS but no ROOT 6 there"
(echoes the path).
Doc fixes
- README.md, README_OSX.md: CMAKE_FLAGS.md references corrected to BUILD_OPTIONS.md.
- README.md: dropped future from the required-Python-modules list (it's not actually checked).
Cosmetic
- CMakeLists.txt: build-type message no longer wraps undefined colour vars (printed before utilities.cmake is included). Per your request,
kept in place — colour stripped instead of moved.
- CMakeLists.txt: Cmake 3.0 → CMake 3.0 in CMP0048 comment.
- CMakeLists.txt: Python_ADDITIONAL_VERSIONS extended to 3.12, 3.13.
- cmake/optional.cmake: removed unreachable LAPACK message after the FATAL_ERROR.
ChrisJChang
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR collects a number of tiny fixes to the cmake system, to correct some small bugs and typos, and improve some error messages to make them more useful.
Bugs fixed:
Improved messages:
Documentation fixes:
Typos, etc.: