Conversation
There was a problem hiding this comment.
Perhaps we could check that there are no running or pending tasks before deciding not to log?
There was a problem hiding this comment.
Absolutely. So when is the normal clause invoked? And how is the logging output used?
There was a problem hiding this comment.
It is used to see the scheduler stopped cleanly. The scheduler does not stop very often, so this is useful information to have for debugging.
There was a problem hiding this comment.
IMHO, it is better to be explicit rather than implicitly print nothing if it stopped cleanly.
|
Yup, fair enough. |
|
Re-opening this because gascheduler taints the test console logs. (It didn't use to do it but I can't figure out why so I suggest we merge this instead) see https://magnum.travis-ci.com/GameAnalytics/gastream/jobs/18898896 |
Don't log on normal stop of gascheduler
Don't log on normal stop of gascheduler
Don't log on normal stop of gascheduler
4 participants
No description provided.