chore: support Go 1.24#12
Merged
Nicholas Wiersma (nrwiersma) merged 1 commit intomainfrom Mar 12, 2025
Merged
Conversation
Nicholas Wiersma (nrwiersma)
requested review from
Christian R (antiphp) and
Emirhan Mutlu (jestress)
Emirhan Mutlu (jestress)
approved these changes
Mar 11, 2025
Christian R (antiphp)
approved these changes
Mar 11, 2025
| go-version: [ "1.23", "1.24" ] | ||
| env: | ||
| GOLANGCI_LINT_VERSION: v1.61.0 | ||
| GOLANGCI_LINT_VERSION: v1.64.6 |
Contributor
There was a problem hiding this comment.
Can't we remove this, now that we have updated the workflow template?
https://github.com/GameFabric/workflows/pull/15
Contributor
Author
There was a problem hiding this comment.
no, this is OSS and does not use workflow which is internal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal of this PR
This adds support for Go 1.24, but leaves the min go version at 1.23, to ensure no pipeline breaks for older projects.
How did I test it?