Permissions edge-case during updates

[grandprixgp]

User Story

If you don't have permissions over the $rootdir folder itself, but only the relevant contents of $rootdir, updates will fail because sed attempts to drop temporary files into this folder. In addition to this, when an update fails at this section, the backup previously made is not restored to $rootdir which causes the gameserver.sh to report an invalid gameserver:

[ FAIL ] unknown game server

Basic info

• Distro: All
• Game: N/A
• Command: update
• LinuxGSM version: <= v20.5.0

Further Information

The bug occurs because we don't utilize $tmpdir to sed our changes, additionally we do not restore the backup previously created here.

To Reproduce

Steps to reproduce the behaviour:

1. Set permissions such that you have the required permissions for all LGSM files and folders but not the root directory itself.
2. Launch an update
3. gameserver.sh becomes invalid and update fails.

Expected behaviour

At the very least the backup should be restored in this case, but it is trivial to remove the case entirely by utilizing the $tmpdir rather than the $rootdir for sed changes.

[issue-label-bot]

Issue-Label Bot is automatically applying the label type: bug to this issue, with a confidence of 0.94. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

[dgibbs64]

Why would someone not have permissions to the rootdir?

[grandprixgp]

In my case it's a side effect of migrating permissions while maintaining the original directory structure, I don't want to grant permissions on $rootdir. However it is a very niche situation and would be fixed by spending the time to properly migrate. Still, this being such a trivial fix (and I believe backup should be restored regardless, no?) I'd argue its worth implementing.