centos tmux non-rpm causes false warnings

[JHiemenz]

CentOS 6.7, installed tmux manually, non-rpm version .

tf2server script only checks dependencies by checking for existence of installed RPM, instead of actual binary.

Would there be a way to check if tmux is found in path (tmux -V ?)

This would prevent the following message for every stop/start/update/etc command issued to tf2server:

[ WARN ] Stopping tf2-server: Checking dependencies: Dependency missing: tmux

Info! tf2 does not have sudo access. manually install dependencies

yum install tmux

[dgibbs64]

Good point. I didn't think about that :-P. I will have to address this

[jaredballou]

Why did you install outside the RPM? It's bad practice, and if it's installed without RPM it means we can't easily verify the requirements are actually met.

[JHiemenz]

The existence of the RPM isn't actually checking the file/program is
actually there and accessible, or correct version. it is just checking RPM
install log for version installed at some point of history.
One can check if RPM is installed and continue to find another fatal error,
such as the program is missing for some reason.

For an executable program, like tmux, I prefer to check the program is
there (right now) and can be accessed, and what version it is. Checking
output of 'which' show me the program is present, in my path:
[tf2@tf2 ~]$ which tmux
/usr/local/bin/tmux

checking version shows me I can execute and validate version is recent
enough:
[tf2@tf2 ~]$ tmux -V
tmux 2.1

and therein is the reason I do not use the RPM. I do not wish to use an
outdated version of tmux. The RPM version in CentOS epel for 6.7 is way
back at tmux version 1.6.

On Thu, Mar 10, 2016 at 9:11 AM, Jared Ballou notifications@github.com
wrote:

Why did you install outside the RPM? It's bad practice, and if it's
installed without RPM it means we can't easily verify the requirements are
actually met.

—
Reply to this email directly or view it on GitHub
#736 (comment).

[iNilo]

Removed my RPM, build from source

Aug 06 01:00:03 csgo-server: CHECK: FATAL: Tmux is not installed
Aug 06 01:00:03 csgo-server: CHECK: FATAL: check_tmux.sh exiting with code: 1

which tmux
/usr/local/bin/tmux

whereis tmux
tmux: /usr/local/bin/tmux

tmux -V
tmux 2.3

[dgibbs64]

That's odd the code uses which to check for tmux :-/

[iNilo]

When manually executing the check_tmux.sh it seems to detect it. (which it should).

This might be a env/cron problem on my side

[dgibbs64]

Could be. Hopefully you can find a solution. Let us know if you think that there is anything we can do to in LGSM to resolve this type of issue.

[dgibbs64]

Please can I get feedback. Change to the development branch in your scripts and test for me to ensure this is working for you. Once you are happy I can merge.

Thanks