Skip to content

Minecraft fix for improper default executable#1283

Merged
dgibbs64 merged 2 commits intodevelopfrom
hotfix/minecraft
Feb 1, 2017
Merged

Minecraft fix for improper default executable#1283
dgibbs64 merged 2 commits intodevelopfrom
hotfix/minecraft

Conversation

@braunsonm
Copy link
Copy Markdown
Contributor

I have no idea how this was not noticed before.
Without this change the following will happen:
[ FAIL ] Starting mc-server: Executable java -Xmx1024M -jar minecraft_server.jar was not found

@UltimateByte
Copy link
Copy Markdown
Contributor

https://github.com/GameServerManagers/LinuxGSM/blob/develop/lgsm/functions/check_executable.sh#L11

if [ ! -f "${executabledir}/${execname}" ]; then
Would expand to something like:
"/home/minecraft/serverfiles/java -Xmx1024M -jar /home/minecraft/serverfiles/minecraft_server.jar"

Would it work with the first part of the expand being totally wrong?

@braunsonm
Copy link
Copy Markdown
Contributor Author

Interesting. I'm not sure why that check doesn't work right now without the filesdir line I added.

@UltimateByte
Copy link
Copy Markdown
Contributor

We should add the full path of the non found executable error message.

@braunsonm
Copy link
Copy Markdown
Contributor Author

What do you mean @UltimateByte

@UltimateByte
Copy link
Copy Markdown
Contributor

Well, the non found executable error message that i made just shows the not found file's name. It should tell the full path. I'm still concerced about my first message though, i'll have a look if needed Sleeping a bit for now :)

@dgibbs64 dgibbs64 merged commit b554a0e into develop Feb 1, 2017
@UltimateByte
Copy link
Copy Markdown
Contributor

Fixed #1285

@dgibbs64 dgibbs64 deleted the hotfix/minecraft branch February 13, 2017 21:33
@lock
Copy link
Copy Markdown

lock Bot commented Jul 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Jul 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants