Skip to content

Add tmux dimensions#1397

Merged
dgibbs64 merged 6 commits intoGameServerManagers:developfrom
TechNZ:master
Apr 12, 2017
Merged

Add tmux dimensions#1397
dgibbs64 merged 6 commits intoGameServerManagers:developfrom
TechNZ:master

Conversation

@TechNZ
Copy link
Copy Markdown
Contributor

@TechNZ TechNZ commented Apr 10, 2017

added the ability to set the default width and height of the detatched session using variables tmux_width and tmux_height.

these variables may be set at a local level or system wide.

the script checks if the input from the variables is a valid positive integer and if input is not a valid positive integer, sets the values for the tmux to the default values of 80x23

Fixes #1396

dgibbs64 and others added 2 commits March 8, 2017 21:46
added the ability to set the default width and height of the detatched session using variables tmux_width and tmux_height.

these variables may be set at a local level or system wide.

the script checks if the input from the variables is a valid positive integer and if input is not a valid positive integer, sets the values for the tmux to the default values of 80x23
TechNZ added 2 commits April 11, 2017 07:58
'-s' flag had an extra '-'
changed "-" to "_"
TechNZ added 2 commits April 12, 2017 23:09
updated if statements and variables to meet LGSM syntax and naming conventions
corrected a variable name error cause by quickly making changes when tired
@UltimateByte
Copy link
Copy Markdown
Contributor

Much better :p
I suppose @dgibbs64 will accept this, since it doesn't change anything for other users.
We probably should add these parameters to all gameserver files though.

Forgot about branching though.
Basically, this PR should be made to "develop" branch and preferably named "feature/tmux-123" (with 123 being any set of numbers). More info here: https://github.com/GameServerManagers/LinuxGSM/wiki/Branching

@dgibbs64 dgibbs64 changed the base branch from master to develop April 12, 2017 15:37
@dgibbs64
Copy link
Copy Markdown
Member

Looks good to me :). This will be in the next release.

@dgibbs64 dgibbs64 merged commit 88994b8 into GameServerManagers:develop Apr 12, 2017
@TechNZ
Copy link
Copy Markdown
Contributor Author

TechNZ commented Apr 12, 2017

Many thanks for the assistance @UltimateByte , this is my first time using github for any form of developement purpose. so it was a good learning experience.

And many thanks @dgibbs64 for accepting.

@lock
Copy link
Copy Markdown

lock Bot commented Jul 18, 2018

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked as resolved and limited conversation to collaborators Jul 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants