Changed tar exclude to be the configured dir#1508
Merged
dgibbs64 merged 1 commit intoGameServerManagers:developfrom Jul 10, 2017
Merged
Changed tar exclude to be the configured dir#1508dgibbs64 merged 1 commit intoGameServerManagers:developfrom
dgibbs64 merged 1 commit intoGameServerManagers:developfrom
Conversation
Updated the tar exclude to be the configured backup dir, instead of just a hardcoded "backup". This allows for people to change the backup directory location to still be in the game server dir, but in a custom directory. For me specifically it's an NFS mounted directory to backup to my NAS with the cloud backup then enabled on that dir.
Contributor
Author
|
Strange. If I'm reading it right the test scripts were having trouble simply fetching https://raw.githubusercontent.com/GameServerManagers/LinuxGSM/master/lgsm/functions/core_dl.sh? So it's not a problem with my PR? |
Contributor
|
Don't worry about Travis test, it's fixed in the dev branch :) |
Contributor
Author
|
Ha! Ok :) I'm also going to do some comparisons with bzip2 vs gzip, and various compression options to see about time and output file size if there's much of a difference. Not in this PR though. |
Contributor
|
Excellent idea :) |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the tar exclude to be the configured backup dir, instead of just a hardcoded "backup". This allows for people to change the backup directory location to still be in the game server dir, but in a custom directory. For me specifically it's an NFS mounted directory to backup to my NAS with the cloud backup then enabled on that dir.