Skip to content

changed all shebangs to use /usr/bin/env to improve compatibility#1652

Closed
The-M1k3y wants to merge 1 commit intoGameServerManagers:masterfrom
The-M1k3y:master
Closed

changed all shebangs to use /usr/bin/env to improve compatibility#1652
The-M1k3y wants to merge 1 commit intoGameServerManagers:masterfrom
The-M1k3y:master

Conversation

@The-M1k3y
Copy link
Copy Markdown

By changing the shebangs the scripts can be used on systems with non-standard paths without the need to modify them.

@dgibbs64
Copy link
Copy Markdown
Member

@UltimateByte
Copy link
Copy Markdown
Contributor

I can't think of a reason why bash would be installed in a non-standard path. Could you provide an example?

@The-M1k3y
Copy link
Copy Markdown
Author

I'm currently setting up my servers with NixOS, which has the bash executable at /run/current-system/sw/bin/bash.
I understand if you don't want to use the env-shebang, but as far as I can see there are no real disadvantages when using env.

@UltimateByte
Copy link
Copy Markdown
Contributor

Well, that is something to test on supported distro First, including legacy distro. If that only adds more compatibility with no disavantages as you claim, then why not.

But, can't you just symlink /run/current-system/sw/bin/bash and /bin/bash ?

@The-M1k3y
Copy link
Copy Markdown
Author

Yes, I could just symlink the bash to /bin/bash, but that would counterfeit the whole concept of NixOS (since /run/current-system/sw/bin/bash itself is only a symlink).
But you are right, I forgot about the legacy distros. It's probably better to leave it like that for the moment and I just keep working with my fork.

@dgibbs64
Copy link
Copy Markdown
Member

dgibbs64 commented Jan 7, 2019

Closing as no further action required currently

@dgibbs64 dgibbs64 closed this Jan 7, 2019
@ghost ghost removed the Status: being considered label Jan 7, 2019
@dgibbs64 dgibbs64 mentioned this pull request Jun 18, 2019
19 tasks
@lock
Copy link
Copy Markdown

lock Bot commented Jan 7, 2020

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked and limited conversation to collaborators Jan 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants