Skip to content

use branch name while checking for updates#2013

Merged
dgibbs64 merged 1 commit intoGameServerManagers:developfrom
ernado:fix-branch-buildid
Oct 1, 2018
Merged

use branch name while checking for updates#2013
dgibbs64 merged 1 commit intoGameServerManagers:developfrom
ernado:fix-branch-buildid

Conversation

@ernado
Copy link
Copy Markdown
Contributor

@ernado ernado commented Sep 18, 2018

Should fix #1913

With branch -beta beta:

$ ./stserver update
[  OK  ] Update stserver: Checking for update: SteamCMD: No update available

No update available:
	Current version: 3129892
	Available version: 3129892
	https://steamdb.info/app/600760/

Changed to -beta public

$ ./stserver update
[  OK  ] Update stserver: Checking for update: SteamCMD: Update available

Update available:
	Current build: 3129892
	Available build: 3126493
	https://steamdb.info/app/600760/

Applying update...
[  OK  ] Stopping stserver: Graceful: CTRL+c: 3: OK
[  OK  ] Update stserver: SteamCMD
Redirecting stderr to '/home/stserver/Steam/logs/stderr.txt'
[  0%] Checking for available updates...
[----] Verifying installation...
Steam Console Client (c) Valve Corporation
-- type 'quit' to exit --
Loading Steam API...OK.

Connecting anonymously to Steam Public...Logged in OK
Waiting for user info...
OK
 Update state (0x5) validating, progress: 0.00 (0 / 0)
 # ...
 Update state (0x61) downloading, progress: 99.64 (286495326 / 287543902)
Success! App '600760' fully installed.
[  OK  ] Starting stserver: LinuxGSM
[  OK  ] Alert stserver: Sending Discord alert

Back to -beta beta

$ ./stserver update
[  OK  ] Update stserver: Checking for update: SteamCMD: Update available

Update available:
	Current build: 3126493
	Available build: 3129892
	https://steamdb.info/app/600760/

Applying update...
[  OK  ] Stopping stserver: Graceful: CTRL+c: 2
# ...

@ghost ghost added the Status: dev queue label Sep 18, 2018
@ernado
Copy link
Copy Markdown
Contributor Author

ernado commented Sep 18, 2018

Also I think we should strip the -beta prefix from config and assume it by default and use public branch explicitly if not set, because steamcmd will not use public automatically after being on beta branch, only after specifying -beta public.

But it is out of scope of current fix.

@dgibbs64 dgibbs64 changed the base branch from master to develop October 1, 2018 20:13
@dgibbs64
Copy link
Copy Markdown
Member

dgibbs64 commented Oct 1, 2018

the double +app_info_print "${appid}" has been removed in this pr. I think it was originally used as the first attempt always failed. Not sure if the bug still exists though. I will merge. If the issue pops up again then I will re add

@dgibbs64 dgibbs64 merged commit be3c330 into GameServerManagers:develop Oct 1, 2018
@ghost ghost removed the Status: dev queue label Oct 1, 2018
@dgibbs64 dgibbs64 added this to the 181027 milestone Oct 27, 2018
@lock
Copy link
Copy Markdown

lock Bot commented Oct 27, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@lock lock Bot locked and limited conversation to collaborators Oct 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants