Skip to content

Change sudo -v to sudo -n true to resolve #2177#2178

Closed
Bourne-ID wants to merge 5 commits intoGameServerManagers:developfrom
Bourne-ID:develop
Closed

Change sudo -v to sudo -n true to resolve #2177#2178
Bourne-ID wants to merge 5 commits intoGameServerManagers:developfrom
Bourne-ID:develop

Conversation

@Bourne-ID
Copy link
Copy Markdown
Contributor

Description

sudo -v prompts when checking for sudo access even with NoPrompt set in sudoers. See #2177 for more information

Fixes #2177

Type of change

  • Bug fix (non breaking change which fixes an issue)
  • New feature (non breaking change which adds functionality)
  • Refactor (non breaking change restructures existing code)
  • This change requires a documentation update

Checklist

  • My code follows the style guidelines of this project
  • This pull request links to an issue
  • I have performed a self review of my own code
  • I have commented my code, particularly in hard to understand areas
  • I have made corresponding changes to the documentation

@ghost ghost assigned Bourne-ID Feb 4, 2019
@ghost ghost added the status: triage label Feb 4, 2019
@Bourne-ID
Copy link
Copy Markdown
Contributor Author

Bourne-ID commented Feb 4, 2019

This change requests is based off #2177 and for discussion if we want to change sudo -v to sudo -n true especially in AI with NoPrompt scenarios.

No idea why a187361 or 545d3eb was included in this pull especially when the final compare shows these changes are already merged to forked... if it's an issue then I'll re-branch and re-merge.

@Bourne-ID
Copy link
Copy Markdown
Contributor Author

Pr will break usage where a user has passworded sudo. Closing and will reopen without -n after testing.

@Bourne-ID Bourne-ID closed this Feb 5, 2019
@ghost ghost removed the status: triage label Feb 5, 2019
@dgibbs64 dgibbs64 added the outcome: pr rejected Pull Request rejected label Feb 5, 2019
@dgibbs64 dgibbs64 added pr-rejected and removed outcome: pr rejected Pull Request rejected labels Jun 19, 2019
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Dec 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Auto Install (ai) prompts for sudo password even with NoPasswd

2 participants