Change autoinstall sudo check to resolve #2177#2181
Merged
dgibbs64 merged 1 commit intoGameServerManagers:developfrom Feb 5, 2019
Merged
Change autoinstall sudo check to resolve #2177#2181dgibbs64 merged 1 commit intoGameServerManagers:developfrom
dgibbs64 merged 1 commit intoGameServerManagers:developfrom
Conversation
Changed sudo -v to sudo -n true in ai mode to prevent password prompt
dgibbs64
approved these changes
Feb 5, 2019
Contributor
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
sudo -v prompts when checking for sudo access even with NoPrompt set in sudoers, likewise it will prompt when in auto-install mode. See #2177 for more information as this pull request will ensure no prompt is displayed for Auto-Install, but will prompt if a user has the password set up for sudo in normal mode.
This PR overrules #2180 as it squashes commits
Fixes #2177
Type of change
Checklist
PR will not be merged until all steps are complete.
developbranch as its base.Provide Github Email
Fill out below info or tick box below:
All pull requests will now be squashed to create a tidy commit history and simplify changelog creation. You can provide either your own email or a GitHub-provided no-reply email.
When a PR is squashed the author becomes the person who squashed the PR. This removes you as the author of your own PR.
The only workaround for this is to add your details as a co-author. More info about co-authors can be found here.
Documentation
If documentation does need updating either update it by creating a PR (preferred) or request a documentation update.
Thank you for your Pull Request!