Skip to content

[WIP] feat(newserver) PaperMC#2352

Closed
0DUDDU wants to merge 9 commits intoGameServerManagers:developfrom
0DUDDU:feature/AddPaperMCServer
Closed

[WIP] feat(newserver) PaperMC#2352
0DUDDU wants to merge 9 commits intoGameServerManagers:developfrom
0DUDDU:feature/AddPaperMCServer

Conversation

@0DUDDU
Copy link
Copy Markdown
Contributor

@0DUDDU 0DUDDU commented May 11, 2019

PaperMC is a Minecraft server fork of spigot (which is a fork of Bukkit) with some improvement and also an API to check when update is needed
It support version selection via the API

Image of Version selector

Tell me if a have missed something when adding new server type to LGSM

Type of change

  • Bug fix (change which fixes an issue).
  • New feature (change which adds functionality).
  • New Server (new server added).
  • Refactor (restructures existing code).
  • Comment update (typo, spelling, explanation, examples, etc).
  • This change requires a documentation update.

Checklist

  • This code follows the style guidelines of this project.
  • This pull request uses the develop branch as its base.
  • I have performed a self-review of my own code.
  • I have squashed commits.
  • I have commented my code, particularly in hard to understand areas.
  • I have made corresponding changes to the documentation if required.

Provide Github Email

Co-authored-by: DUDU54 <14166148+DUDU54@users.noreply.github.com>

PaperMC is a Minecraft server fork of spigot (which is a fork of Bukkit) with some improvement and also an API to check when update is needed
It support version selection via the API
@dgibbs64 dgibbs64 changed the title [WIP]add PaperMC Server [WIP] feat(newserver) PaperMC May 11, 2019
@dgibbs64
Copy link
Copy Markdown
Member

@Dudu54 you might be a good person to ask. There are so many different "versions" of mincecraft that I have been reluctant to support all but vanilla. Is there an article explaining what the different versions are all about?

@GameServerManagers GameServerManagers deleted a comment May 12, 2019
@0DUDDU
Copy link
Copy Markdown
Contributor Author

0DUDDU commented May 12, 2019

@dgibbs64
Copy link
Copy Markdown
Member

@Dudu54 thanks. Clear as mud haha. I think because of the complexity of the versions it makes sense for each Minecraft variant to have its own server version.

@dgibbs64
Copy link
Copy Markdown
Member

@Dudu54 would it be a good idea to do a version select for vanilla minecraft as well?

@GameServerManagers GameServerManagers deleted a comment May 12, 2019
@0DUDDU
Copy link
Copy Markdown
Contributor Author

0DUDDU commented May 12, 2019

@dgibbs64 Sure, i will look to do that.

Also, where can i move the selection function which take a string with option on each line to not duplicate the code for each server type

@dgibbs64
Copy link
Copy Markdown
Member

core_messages might be a good place as its UI related

@GameServerManagers GameServerManagers deleted a comment May 12, 2019
@kyleedwardsny
Copy link
Copy Markdown

I think because of the complexity of the versions it makes sense for each Minecraft variant to have its own server version.

This gets even more complicated when you add modpacks into the picture. What is the "version" at that point? Do we add a different server for every modpack in existence?

FWIW, I am using Minecraft with the Sky Factory 4 modpack. To get it to work, I just copied my existing server files into the serverfiles directory, and added a symlink minecraft_server.jar that just points to the Forge JAR.

@GameServerManagers GameServerManagers deleted a comment Jun 10, 2019
@dgibbs64 dgibbs64 closed this Jun 15, 2019
@dgibbs64 dgibbs64 reopened this Jun 15, 2019
@dgibbs64 dgibbs64 added the type: game server request Request for a new server label Jun 19, 2019
@GameServerManagers GameServerManagers deleted a comment Jul 12, 2019
@GameServerManagers GameServerManagers deleted a comment Aug 30, 2019
@GameServerManagers GameServerManagers deleted a comment Oct 8, 2019
@GameServerManagers GameServerManagers deleted a comment Oct 8, 2019
@dgibbs64 dgibbs64 closed this Nov 15, 2019
@dgibbs64 dgibbs64 reopened this Nov 15, 2019
@legendofmiracles
Copy link
Copy Markdown

are there plans to merge this soon? this PR is kind of dead

Copy link
Copy Markdown
Member

@h3o66 h3o66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase and resolve the conflicts

@dgibbs64 dgibbs64 closed this Jan 27, 2021
@dgibbs64 dgibbs64 deleted the branch GameServerManagers:develop January 27, 2021 20:51
@dgibbs64 dgibbs64 reopened this Jan 27, 2021
@h3o66 h3o66 added the branch conflicts Branch of pr has conflicts that need to be worked on label Jan 28, 2021
@dgibbs64
Copy link
Copy Markdown
Member

Minecraft is being reviewer by me currently. This PR will be part of that.

@h3o66
Copy link
Copy Markdown
Member

h3o66 commented Feb 23, 2021

closing this in favour of #3292

@h3o66 h3o66 closed this Feb 23, 2021
@dgibbs64 dgibbs64 linked an issue Feb 26, 2021 that may be closed by this pull request
4 tasks
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

branch conflicts Branch of pr has conflicts that need to be worked on game: Minecraft type: game server request Request for a new server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Server Request] PaperMC and Waterfall

6 participants